Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github-actions broken link #78

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

adamjstewart
Copy link
Member

The "github-actions" button on https://spack.github.io/spackbot/ is broken. I don't think https://github.com/apps/spack-bot or any permutation of that actually exists. Let's just remove the button.

@vsoch
Copy link
Member

vsoch commented Mar 16, 2023

The repository (if I remember) used to be named with a dash, and it was renamed but nobody updated that link.

@adamjstewart
Copy link
Member Author

The link without the dash also doesn't work

@scottwittenburg
Copy link
Collaborator

scottwittenburg commented Mar 16, 2023

I'm curious who or what is responsible for the redirection that seems to keeping those other links working.

@scottwittenburg
Copy link
Collaborator

But otherwise I have no objection to removing the github-actions link.

@adamjstewart
Copy link
Member Author

Looks like redirect happen automatically when you rename a repo: https://github.blog/2013-05-16-repository-redirects-are-here/

I'll update the old links anway

@adamjstewart
Copy link
Member Author

Still a few references to spack-bot in the security keys, was too afraid to mess with those

@scottwittenburg
Copy link
Collaborator

I'll update the old links anway

Thanks for doing that!

@scottwittenburg scottwittenburg merged commit a0bb61d into spack:main Mar 16, 2023
@adamjstewart adamjstewart deleted the docs/links branch March 16, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants