Add support for triple ///, //! and /*! style comments + basic Rust support #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ | |||
| { "key": "setting.auto_indent", "operator": "equal", "operand": true, "match_all": true }, | |||
| { "key": "selection_empty", "operator": "equal", "operand": true, "match_all": true }, | |||
| { "key": "auto_complete_visible", "operator": "equal", "operand": false, "match_all": true }, | |||
| { "key": "preceding_text", "operator": "regex_contains", "operand": "^\\s*(\\/\\*|###)\\*\\s*$", "match_all": true } | |||
| { "key": "preceding_text", "operator": "regex_contains", "operand": "^\\s*(\\/\\*|###)[\\*!]\\s*$", "match_all": true } | |||
There was a problem hiding this comment.
Minor point here, but inside of a character class block ([square brackets]), the asterisk has no special meaning, so it doesn't need escaping. "^\\s(\\/\\*|###)[*!]\\s*$"
|
Sorry for taking so long to look at this. It looks pretty good, but would you be able to target the PR to the |
|
Alright, opened #223 against develop. Fixed the greedy escaping of wildcards too. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for:
///triple slash docblocks (also fixes Triple slash doc style #214).//!and/*!comments for documenting modules.I hope it's all reasonable changes :)