Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified dockerfile #11

Merged
merged 3 commits into from
Feb 13, 2015
Merged

Simplified dockerfile #11

merged 3 commits into from
Feb 13, 2015

Conversation

rothgar
Copy link
Contributor

@rothgar rothgar commented Feb 12, 2015

Changed the container so it is easier to manage going forward.

  • Based on official ruby image instead of ubuntu 13.10 (EOL)
  • Installed latest nodejs and npm from nodesource
  • run web interface under hubot user for security and fix problem creating new bots using root permissions

Dockerfile builds and works on my system with db and storage containers. I'm using Docker 1.4.1

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.48% when pulling ec9c554 on rothgar:ruby-container into 4414135 on spajus:master.

@rothgar
Copy link
Contributor Author

rothgar commented Feb 12, 2015

I forgot my .gitignore was ignoring the Gemfile.lock which is needed for the ruby image.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.48% when pulling ee3e08e on rothgar:ruby-container into 4414135 on spajus:master.

@spajus
Copy link
Owner

spajus commented Feb 13, 2015

Thank you!

spajus added a commit that referenced this pull request Feb 13, 2015
@spajus spajus merged commit 8de5363 into spajus:master Feb 13, 2015
@rothgar rothgar deleted the ruby-container branch February 13, 2015 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants