Relax pronto version restriction #4
Conversation
|
Ah, I've just seen there may be a breaking change for this (which should have been a new major version of pronto I guess). I'll close this PR, but look forward to a new version of |
| @@ -17,7 +17,7 @@ Gem::Specification.new do |spec| | |||
| spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) | |||
| spec.require_paths = ['lib'] | |||
|
|
|||
| spec.add_runtime_dependency('pronto', '~> 0.5.0') | |||
| spec.add_runtime_dependency('pronto', '~> 0.5') | |||
There was a problem hiding this comment.
~> 0.5.0 and ~> 0.5 are both equal, as ~> allows minor version to go up.
There was a problem hiding this comment.
It's a little different...
~> 0.5.0 will allow 0.5.0, 0.5.1, 0.5.2 ... 0.5.9999 but that's it.
~> 0.5 will allow 0.5.0, 0.5.1, 0.5.2 ... 0.6.0, 0.6.1, 0.6.2 ... 0.9999.9999
Right now, for example, the latest version of pronto is 0.6.0, but pronto-jscs cannot use it. (Which is lucky, in this case, as pronto has a breaking method signature change in a minor version update (0.5.0 - 0.6.0), which shouldn't happen).
There was a problem hiding this comment.
Ah, wasn't aware of that. Anyway, #1 prevents using pronto-jscs with pronto 0.6.x for now.
There isn't really a need to lock to a minor pronto version, and when using many pronto support gems, the chances of updating when one moves to a new minor version of pronto become very small.