Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gulp util #157

Merged
merged 4 commits into from
Dec 29, 2017
Merged

Remove gulp util #157

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
357ab98
[gulp-util/File] use Vinyl directly
spalger Dec 28, 2017
154180d
[gulp-util/PluginError] use plugin-error directly
spalger Dec 28, 2017
5eaabdd
add yarn.lock file for dev
spalger Dec 28, 2017
5f621f8
vinyl is only used in testing
spalger Dec 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ test
.jshintignore
.jshintrc
.travis.yml
gulpfile.js
gulpfile.js
yarn.lock
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@
"gulpplugin"
],
"dependencies": {
"gulp-util": "^3.0.0",
"lodash": "^4.12.0",
"minimatch": "^3.0.3",
"plugin-error": "^0.1.2",
"rcloader": "^0.2.2",
"through2": "^2.0.0"
"through2": "^2.0.0",
"vinyl": "^2.1.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a devDep, right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it. You are right: vinyl is only used for the tests and should be a devDependency.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to be careful with this because we don't want people inadvertently depending on vinyl if they aren't using it outside of DevDeps.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phated!

},
"peerDependencies": {
"jshint": "2.x"
Expand Down
2 changes: 1 addition & 1 deletion src/fileIgnored.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ var dirname = require('path').dirname;
var join = require('path').join;
var sep = require('path').sep;
var RcLoader = require('rcloader');
var PluginError = require('gulp-util').PluginError;
var PluginError = require('plugin-error');

var ignoreLoader = new RcLoader('.jshintignore', {}, {
loader: function (path) {
Expand Down
2 changes: 1 addition & 1 deletion src/lint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var path = require('path');
var PluginError = require('gulp-util').PluginError;
var PluginError = require('plugin-error');
var RcLoader = require('rcloader');
var jshintcli = require('jshint/src/cli');
var minimatch = require('minimatch');
Expand Down
2 changes: 1 addition & 1 deletion src/reporters/fail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var path = require('path');
var stream = require('../stream');
var PluginError = require('gulp-util').PluginError;
var PluginError = require('plugin-error');
var reduce = require('lodash/reduce');

module.exports = function (opts) {
Expand Down
2 changes: 1 addition & 1 deletion src/reporters/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var PluginError = require('gulp-util').PluginError;
var PluginError = require('plugin-error');
var stream = require('../stream');
var defaults = require('lodash/defaults');

Expand Down
2 changes: 1 addition & 1 deletion test/specs/linting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var Fixture = require('../util').Fixture;
var PluginError = require('gulp-util').PluginError;
var PluginError = require('plugin-error');
var jshint = require('../../src');

describe('linting', function () {
Expand Down
4 changes: 2 additions & 2 deletions test/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var isString = require('lodash/isString');
var jshint = require('../');
var gutil = require('gulp-util');
var Vinyl = require('vinyl');
var join = require('path').join;
var extname = require('path').extname;
var fs = require('fs');
Expand All @@ -22,7 +22,7 @@ function File(opts) {
? new Buffer(opts.contents, 'utf8')
: fs.readFileSync(path);

return new gutil.File({
return new Vinyl({
cwd: opts.cwd || ROOT,
base: opts.base || ROOT,
path: path,
Expand Down