Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to configure the stream #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ericjperry
Copy link

Needed the ability to control the stream timeout, so I added in the stream configuration to the gulp-jshint exported function.

@Slayer95
Copy link
Contributor

@spalger, any interest in merging this or an equivalent feature?

@talberto-zz
Copy link

+1 for this PR. As mentioned in #88, the stream timeout isn't configurable. It's just a matter of correctly passing the opt parameter to the stream function. Any chance this PR will be merged any time soon?

@spalger
Copy link
Owner

spalger commented Jun 2, 2015

@Slayer95 @TAlberto honestly I would accept a PR to remove the timeout stuff from the stream module if you're up for it.

I'm not a fan of the API implemented here, and the timeout was really just designed as a backup. I don't think there's any reason to leave it in any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants