fix screenshot saving and error

packages/kbn-test/src/page_load_metrics/navigation.ts

@@ -22,14 +22,13 @@ import Url from 'url';
 import _ from 'lodash';
 import puppeteer from 'puppeteer';
 import { resolve } from 'path';
-import { ToolingLog, REPO_ROOT } from '@kbn/dev-utils';
+import { ToolingLog } from '@kbn/dev-utils';
 import { ResponseReceivedEvent, DataReceivedEvent } from './event';
 
-const failureDir = resolve(REPO_ROOT, 'x-pack/test/page_load_metrics/screenshots/failure');
-
 export interface NavigationOptions {
   headless: boolean;
   appConfig: { url: string; username: string; password: string };
+  screenshotsDir?: string;
 }
 
 export type NavigationResults = Map<string, Map<string, FrameResponse>>;
@@ -137,15 +136,24 @@ export async function navigateToApps(log: ToolingLog, options: NavigationOptions
             continue;
           }
 
-          await page.bringToFront();
+          const failureDir = options.screenshotsDir
+            ? resolve(options.screenshotsDir, 'failure')
+            : resolve(__dirname, 'screenshots/failure');
+          const screenshotPath = resolve(
+            failureDir,
+            `${app.path.slice(1).split('/').join('_')}_navigation.png`
+          );
           Fs.mkdirSync(failureDir, { recursive: true });
+
+          await page.bringToFront();
           await page.screenshot({
-            path: resolve(failureDir, `${app.path.split('/').join('_')}_navigation.png`),
+            path: screenshotPath,
             type: 'png',
             fullPage: true,
           });
+          log.debug(`Saving screenshot to ${screenshotPath}`);
 
-          throw error;
+          throw new Error(`Page load timeout: ${app.path} not loaded after 30 seconds`);
         }
       }
 

x-pack/test/page_load_metrics/runner.ts

@@ -16,6 +16,8 @@ export async function PuppeteerTestRunner({ getService }: FtrProviderContext) {
   const config = getService('config');
   const esArchiver = getService('esArchiver');
 
+  const screenshotsDir = config.get('screenshots.directory');
+
   await esArchiver.load('default');
   const metrics = await capturePageLoadMetrics(log, {
     headless: true,
@@ -24,6 +26,7 @@ export async function PuppeteerTestRunner({ getService }: FtrProviderContext) {
       username: config.get('servers.kibana.username'),
       password: config.get('servers.kibana.password'),
     },
+    screenshotsDir,
   });
   const reporter = CiStatsReporter.fromEnv(log);