Encode logger metadata as string. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid a potential issue where JSON logs are parsed and numbers are treated as floats. This can lead to the trace and span ids losing precision when read from JSON. If you look at the DataDog docs for other languages, you can see this. See: https://docs.datadoghq.com/tracing/connect_logs_and_traces/ruby/
|
More or less a dup of #117 |
zachdaniel
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid a potential issue where JSON logs are parsed and numbers are
treated as floats. This can lead to the trace and span ids losing
precision when read from JSON.
If you look at the DataDog docs for other languages, you can see this.
See: https://docs.datadoghq.com/tracing/connect_logs_and_traces/ruby/
Fixes #126