Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require that the env be specified #75

Merged
merged 1 commit into from Aug 29, 2018
Merged

Don't require that the env be specified #75

merged 1 commit into from Aug 29, 2018

Conversation

GregMefford
Copy link
Member

When working on the spandex_datadog sender, I realized that we don't currently have a way to not send the env with the spans. With Datadog, if you don't specify an env in the application like this, it will use the env configured in the trace collector agent. This PR makes it possible to do so, and I have another PR ready on the spandex_dagtadog repo that supports this from that end.

@coveralls
Copy link

coveralls commented Aug 29, 2018

Pull Request Test Coverage Report for Build 328

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.278%

Totals Coverage Status
Change from base Build 319: 0.0%
Covered Lines: 195
Relevant Lines: 237

💛 - Coveralls

@zachdaniel
Copy link
Member

Merge at your liesure.

@GregMefford
Copy link
Member Author

Coveralls won't let me. 😭 I think it was confused because the Travis build failed the first time and I re-ran it but coveralls didn't update its status.

@GregMefford
Copy link
Member Author

Ok, amended the commit and got it to give me a green check, but I still can't merge due to user permissions.

@zachdaniel zachdaniel merged commit 89f852b into master Aug 29, 2018
@GregMefford GregMefford deleted the optional_env branch August 29, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants