Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beeper-maintained bridges fail to build #1719

Closed
Myned opened this issue Mar 29, 2022 · 6 comments
Closed

Beeper-maintained bridges fail to build #1719

Myned opened this issue Mar 29, 2022 · 6 comments

Comments

@Myned
Copy link

Myned commented Mar 29, 2022

Describe the bug
Beeper-maintained bridges (at least Discord and Slack) fail to build due to GitHub's deprecation of git:// and ssh:// protocols. The docker images are likely unaffected.

To Reproduce
My vars.yml file looks like this:

matrix_mx_puppet_discord_enabled: true
matrix_mx_puppet_discord_container_image_self_build: true

Expected behavior
Bridges build successfully.

Actual behavior
Build fails with error:

fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
The command '/bin/sh -c yarn && cd packages/mx-puppet-discord && yarn build' returned a non-zero code: 128

Matrix Server:

  • OS: Arch Linux
  • Architecture: arm64

Ansible:
The problem lies with the upstream monorepo.

Client:
N/A

Additional context
I have submitted upstream MR !35 a week ago, which would also close the related issue. My fork can be used as follows until it is resolved. The only difference between the fork and upstream is a dirty fix to replace the unauthenticated protocols with git+https:// in relevant lock files. I will attempt to merge any changes made upstream until building is fixed. If this is an acceptable interim solution, I would be happy to open a PR.

For Discord (tested on arm64):

matrix_mx_puppet_discord_enabled: true
matrix_mx_puppet_discord_container_image_self_build: true
matrix_mx_puppet_discord_container_image_self_build_repo: "https://gitlab.com/Myned/mx-puppet-monorepo"

For Slack (untested):

matrix_mx_puppet_slack_enabled: true
matrix_mx_puppet_slack_container_image_self_build: true
matrix_mx_puppet_slack_container_image_self_build_repo: "https://gitlab.com/Myned/mx-puppet-monorepo"
@spantaleev
Copy link
Owner

Thank you! 👍

I've temporarily switched the playbook to use your fork, so that self-building can work for the time being. I'm following the MR for the Beeper fork and will switch us back to it's fixed.

@Myned
Copy link
Author

Myned commented Mar 30, 2022

Understood! Glad to have been of service. I'll report back tomorrow to confirm whether your changes fix self-building with the repo override removed on my system.

@danrmiller
Copy link

If you are not self-building, it still looks for matrix_mx_puppet_slack_version: 40f3142032bacec6333f4bbc051d5e30af88de9c at registry.gitlab.com/beeper/mx-puppet-monorepo/slack and won't find it.

@Myned
Copy link
Author

Myned commented Mar 30, 2022

@spantaleev
!35 was just merged, so I think this can be reverted, which would also fix the above issue.

spantaleev added a commit that referenced this issue Mar 31, 2022
…ord/mx-puppet-slack"

This reverts commit 0103d92.

The same fix has now been merged upstream
(https://gitlab.com/beeper/mx-puppet-monorepo/-/merge_requests/35), so
we don't need to use a fork anymore.

Related to #1719
@spantaleev
Copy link
Owner

Oh, you're right, @danrmiller! I missed that.

Reverted. It should be fine for everyone now!

@Myned
Copy link
Author

Myned commented Apr 1, 2022

Commenting to confirm that mx-puppet-discord built successfully after removing my fork from the vars on my system.

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants