-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beeper-maintained bridges fail to build #1719
Comments
Thank you! 👍 I've temporarily switched the playbook to use your fork, so that self-building can work for the time being. I'm following the MR for the Beeper fork and will switch us back to it's fixed. |
Understood! Glad to have been of service. I'll report back tomorrow to confirm whether your changes fix self-building with the repo override removed on my system. |
If you are not self-building, it still looks for matrix_mx_puppet_slack_version: 40f3142032bacec6333f4bbc051d5e30af88de9c at registry.gitlab.com/beeper/mx-puppet-monorepo/slack and won't find it. |
@spantaleev |
…ord/mx-puppet-slack" This reverts commit 0103d92. The same fix has now been merged upstream (https://gitlab.com/beeper/mx-puppet-monorepo/-/merge_requests/35), so we don't need to use a fork anymore. Related to #1719
Oh, you're right, @danrmiller! I missed that. Reverted. It should be fine for everyone now! |
Commenting to confirm that mx-puppet-discord built successfully after removing my fork from the vars on my system. Thanks for the quick response! |
Describe the bug
Beeper-maintained bridges (at least Discord and Slack) fail to build due to GitHub's deprecation of
git://
andssh://
protocols. The docker images are likely unaffected.To Reproduce
My
vars.yml
file looks like this:Expected behavior
Bridges build successfully.
Actual behavior
Build fails with error:
Matrix Server:
Ansible:
The problem lies with the upstream monorepo.
Client:
N/A
Additional context
I have submitted upstream MR !35 a week ago, which would also close the related issue. My fork can be used as follows until it is resolved. The only difference between the fork and upstream is a dirty fix to replace the unauthenticated protocols with
git+https://
in relevant lock files. I will attempt to merge any changes made upstream until building is fixed. If this is an acceptable interim solution, I would be happy to open a PR.For Discord (tested on arm64):
For Slack (untested):
The text was updated successfully, but these errors were encountered: