Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to official coturn image #1009

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

thedanbob
Copy link
Contributor

Coturn got an official image recently (coturn/coturn#746) from the maintainer of instrumentisto/coturn. As far as I can tell the original image isn't deprecated yet but probably will be soon, e.g. instrumentisto/coturn-docker-image#37 (comment).

@spantaleev
Copy link
Owner

Thanks! 👍

I wonder if we need NET_BIND_SERVICE if we're not asking it to bind to privileged ports (<=1023). Have you tested if it works without this?

@thedanbob
Copy link
Contributor Author

I did, unfortunately it doesn't start due to this line in the Dockerfile: https://github.com/coturn/coturn/blob/b31b0049220ef26e87d784f65e3db286cbdc50a2/docker/coturn/alpine/Dockerfile#L120

@spantaleev spantaleev merged commit 7eda6a3 into spantaleev:master Apr 19, 2021
@spantaleev
Copy link
Owner

That's somewhat unfortunate, but it's no big deal.

Thanks for switching us to the official image! 👍

@thedanbob thedanbob deleted the coturn-official branch April 19, 2021 15:57
spantaleev added a commit that referenced this pull request Apr 24, 2021
spantaleev added a commit that referenced this pull request May 10, 2021
689dcea wasn't enough. The `upstream/..` tags are
just upstream sources, without the alpine-based Dockerfile.
We need to use the `docker/..` tags for that (or `master`)

Fixes #1032

Fixes #1023

Related to #1009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants