Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-build arm64 version of Hydrogen image #2336

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattcen
Copy link
Contributor

@mattcen mattcen commented Dec 12, 2022

This PR is pending element-hq/hydrogen-web#948, but assuming that gets merged, this one will be good to go; I've already tested that the resulting arm64 image works on my arm64 system.

@saket424
Copy link

saket424 commented Jan 7, 2023

@mattcen
I made the one line edit per your pull request and set matrix_architecture: arm64 and matrix_client_hydrogen_enabled: true in vars.xml . When I run

ansible-playbook -i inventory/hosts setup.yml --tags=setup-all

It seems to be downloading the amd64 hydrogen-web docker image instead of the arm64 docker image. What am I doing wrong or am i missing a step?

-matrix_client_hydrogen_container_image_self_build: "{{ matrix_architecture not in ['amd64'] }}"
+matrix_client_hydrogen_container_image_self_build: "{{ matrix_architecture not in ['arm64', 'amd64'] }}"

@saket424
Copy link

saket424 commented Jan 7, 2023

I have temporarily added this line to my vars.xml and it seemed to do the trick

matrix_client_hydrogen_docker_image: 'ghcr.io/mattcen/hydrogen-web@sha256:26efb832e8b3739f2640b3215e03ab6918c51d3a3870f5cc43a7e6c2da14f38f'

@mattcen
Copy link
Contributor Author

mattcen commented Jan 7, 2023

As per the description of this PR (which is still in Draft state for this very reason), it is pending the merging of another PR with the Hydrogen to actually build multi-arch images; currently the only build amd64 images.

@mattcen
Copy link
Contributor Author

mattcen commented Jan 7, 2023

I have temporarily added this line to my vars.xml and it seemed to do the trick

matrix_client_hydrogen_docker_image: 'ghcr.io/mattcen/hydrogen-web@sha256:26efb832e8b3739f2640b3215e03ab6918c51d3a3870f5cc43a7e6c2da14f38f'

Furthermore, my Hydrogen fork is not kept updated with upstream, so I advise against using this container image long-term.

@saket424
Copy link

saket424 commented Jan 7, 2023

Of course, now that I know it is fixable, I'll build my own arm64 docker container using master HEAD. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants