restructured introduction to own webserver deployments #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This PR makes things better.. However, it seems like the documentation was outdated. There's no need to do separate things for worker and non-worker setups - since e9e8434, the playbook works equally well with both of these. As such, I've simplified the documentation in 362954a by completely removing the warning. |
mgoerens
added a commit
to mgoerens/matrix-docker-ansible-deploy
that referenced
this pull request
Apr 12, 2023
Similar to: spantaleev@362954a This warning was added because of: spantaleev#2090 The problem has since been fixed by: spantaleev@e9e8434 This current patch was provoked by: spantaleev#2352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #2351.
This is a bit more opinionated (and maybe even wrong), but I just wrote it in the way I would have needed it.
For me, together with the changes in the first method this would have made the perfect match.