New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix-bot-chatgpt. #2386
Add matrix-bot-chatgpt. #2386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on adding this bot!
I've submited some feedback. Also, it'd be nice to include some documentation (its own docs/
page that says how to best set it up with regards to authentication, etc). It'd be nice to update README.md
and docs/configuring-playbook.md
as well with mentions of this new bot.
Thanks for the feedback, I'll get working on it. I'll also add some basic docs |
We also need to add the needed user to |
Oh, yes.. That'd be great! Some |
That's easy enough, I'll make the change.
Ah, right now that won't work, logging in with a username and a password prints an access token, I can change that though if thats not very good expected behaviour. |
The playbook can register a user with some password and then the bot could start with those credentials automatically. If an access token is needed, the user would need to manually log in at least once to obtain the token.. and then edit |
I'll need to modify the upstream package (I have push permission) to cache the access token I think otherwise we would generate a new login each time. That seems to confuse the encrypted message support in |
If you could do that, that'd be great and seamless! Alternatively, we can ask users to register the bot manually, log in manually to obtain the access token, then populate the config.. and finally do Another alternative may be to make the bot an appservice and it register itself. |
Ok let's do this to get it merged and then I'll take a proper look at doing some cacheing. |
We're in no rush to merge this. Maybe it's better if we do it right from the beginning, so we won't have to redo it twice and potentially think of backward compatibility when we change things. Looks like the documentation page hasn't been updated yet? It assumes that I think it'd be best if you could make it work with a password (and cached access token) upstream, and then for us to jump straight to that. |
Not rushing, ratcheting. I'd rather have a completed solution now and a better solution later potentially than have 80% of a better solution but end up with nothing. I've made the changes but I have no idea when my schedule will allow me to work on cacheing. I don't think we leave this open indefinitely until then. |
Co-Authored-By: Slavi Pantaleev <slavi@devture.com>
Fixed the Do I need to do anything about the warnings e.g.
I based this on the |
You can ignore the warnings. I've fixed up some additional things and merged this! Thank you! |
No description provided.