Adds a self build option for dendrite #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spantaleev
reviewed
May 8, 2023
ibeckermayer
force-pushed
the
dendrite-self-build
branch
from
7249c78
to
bc70921
Compare
to a conditional block, similar to synapse. Also adds the DOCKER_BUILDKIT=1 explicitly to ensure buildkit is used.
ibeckermayer
force-pushed
the
dendrite-self-build
branch
from
bc70921
to
d448cad
Compare
|
Looks good! Thank you! |
spantaleev
added a commit
that referenced
this pull request
May 11, 2023
spantaleev
added a commit
that referenced
this pull request
May 11, 2023
KarolosLykos
pushed a commit
to KarolosLykos/matrix-docker-ansible-deploy
that referenced
this pull request
Mar 5, 2024
KarolosLykos
pushed a commit
to KarolosLykos/matrix-docker-ansible-deploy
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I needed to add an option to self-build dendrite in order to apply a bug patch that's not yet in any official release.
The actual build itself is done with a
ansible.builtin.commandrather than acommunity.docker.docker_image, because the dendrite Docker image uses the BUILDPLATFORM variable, which is a BuildKit/buildx feature, and according to thecommunity.docker.docker_imagedocumentation:Therefore we work around that by avoiding using Docker daemon's api and just using the docker cli via
ansible.builtin.command.