Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory as a git submodule #3086

Closed

Conversation

cvwright
Copy link
Contributor

@cvwright cvwright commented Jan 9, 2024

This PR moves the inventory/ subdirectory out of this git repo and makes it a git submodule.

The idea is that users could keep their inventory in a separate repo of their own, which would be forked from the base inventory repo. This should make it easier for users to keep their host_vars under revision control, without worrying about changes getting lost when merging in the latest version of the playbook from upstream, and without risk of inventory files accidentally being included in public repos or PRs etc.

To make this PR production ready, there are probably a bunch of other things that need to happen:

  • Creating a just recipe to hook up the user's own inventory repo
  • Creating a just recipe to update the inventory repo
  • Make the inventory a dependency for other just recipes (?)
  • Decide whether the base inventory repo should ship as a submodule of the playbook by default, or if it's better to leave it out until the user attaches their own inventory
  • Others?

@cvwright
Copy link
Contributor Author

cvwright commented Jan 9, 2024

Sounds like it's going to be much easier to simply remove inventory from this repo's version control, and let users plug in whatever they want, similar to what the MASH playbook does.

@cvwright cvwright closed this Jan 9, 2024
spantaleev added a commit that referenced this pull request Jan 9, 2024
cvwright pushed a commit to cvwright/matrix-docker-ansible-deploy that referenced this pull request Jan 11, 2024
@cvwright cvwright deleted the cvwright/inventory-submodule branch January 11, 2024 20:50
@reudy14
Copy link

reudy14 commented Jan 13, 2024

The installation guide will need updating

KarolosLykos pushed a commit to KarolosLykos/matrix-docker-ansible-deploy that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants