Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Element] Fix translation on welcome screen #3288

Merged

Conversation

krassle
Copy link
Contributor

@krassle krassle commented Apr 22, 2024

@spantaleev
Copy link
Owner

Seems like we should only merge this once v1.11.65 is actually released.

@krassle
Copy link
Contributor Author

krassle commented Apr 22, 2024

Since v1.11.65 is just around the corner (expected this week), there is no rush.
But it should also be safe to merge now, before the new release, as it has been broken since Element migrated to Localazy back in September last year.
I've tested the effects on the welcome page and now it also respects the language set by the browser as well as a manual switch.
Note that #/login & #/register were are not affected by this.
Thanks! (y)

@spantaleev spantaleev merged commit dd182e3 into spantaleev:master Apr 23, 2024
2 checks passed
spantaleev added a commit that referenced this pull request Apr 23, 2024
@krassle krassle deleted the Element-Fix-translation-on-welcome-screen branch April 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants