Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KG - Report Date Time Zone Incomplete Visit Report #133

Merged
merged 6 commits into from Feb 11, 2016
Merged

KG - Report Date Time Zone Incomplete Visit Report #133

merged 6 commits into from Feb 11, 2016

Conversation

kayla-glick
Copy link
Contributor

No description provided.

amcates
amcates reviewed Feb 11, 2016
View reviewed changes
lib/reports/incomplete_visit_report.rb
@@ -17,7 +17,7 @@ class IncompleteVisitReport < Report

def generate(document)
document.update_attributes(content_type: 'text/csv', original_filename: "#{@params[:title]}.csv")
_24_hours_ago = DateTime.now.ago(24*60*60)
_24_hours_ago = Time.now.ago(24*60*60).utc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.hours.ago.utc

@kayla-glick
Copy link
Contributor Author

@amcates
An alternative to the + 23.hours + 59.minutes + 59.seconds would be + 1.day - 1.second. Would that work better?

@amcates
Copy link
Collaborator

amcates commented Feb 11, 2016

I think either works fine. Ask them team and go with the consensus.

Andrew

On Feb 11, 2016, at 11:23 AM, kyle-glick notifications@github.com wrote:

@amcates
An alternative to the + 23.hours + 59.minutes + 59.seconds would be + 1.day - 1.second. Would that work better?

—
Reply to this email directly or view it on GitHub.

@kayla-glick
Copy link
Contributor Author

@amcates
Even better, we realized theres a Time.tomorrow method, so we did .tomorrow.utc - 1.second

@sparc-request
Copy link
Owner

Nice

On Feb 11, 2016, at 11:30 AM, kyle-glick <notifications@github.commailto:notifications@github.com> wrote:

@amcateshttps://github.com/amcates
Even better, we realized theres a Time.tomorrow method, so we did .tomorrow.utc - 1.second

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/133#issuecomment-182944421.

amcates added a commit that referenced this pull request Feb 11, 2016
@amcates
Merge pull request #133 from sparc-request/kg-report_date_time_zone
9460f31 
KG - Report Date Time Zone Incomplete Visit Report
@amcates amcates merged commit 9460f31 into master Feb 11, 2016
@amcates amcates deleted the kg-report_date_time_zone branch February 11, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kayla-glick @amcates @sparc-request