Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally return the correct funding source, based on whether a p…(2.2.0) #156

Merged
merged 3 commits into from May 5, 2016

Conversation

jleonardw9
Copy link
Collaborator

…rotocol is pending funding or not.

@@ -96,6 +97,14 @@ def protocol_type
sparc_protocol.type
end

def sparc_funding_source
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def sparc_funding_source
funding_source.blank? ? potential_funding_source : funding_source
end

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better, thanks.

@wtholt
Copy link
Contributor

wtholt commented May 5, 2016

Looks good to me

@jleonardw9 jleonardw9 changed the title Conditionally return the correct funding source, based on whether a p… Conditionally return the correct funding source, based on whether a p…(2.2.0) May 5, 2016
@jleonardw9 jleonardw9 merged commit bfee874 into master May 5, 2016
@jleonardw9 jleonardw9 deleted the jl-pricing_setup_mapping branch May 5, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants