ml-fix_email_feature_for_task_creation #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see my comment on the pull request.
Andrew
From: <owner-sparc_request@musc.edu> on behalf of Mark Lohr <notifications@github.com>
Reply-To: sparc-request/sparc-fulfillment <reply@reply.github.com>
Date: Friday, September 15, 2017 at 1:42 PM
To: sparc-request/sparc-fulfillment <sparc-fulfillment@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [sparc-request/sparc-fulfillment] ml-fix_email_feature_for_task_creation (#244)
Upon testing a previous story: https://www.pivotaltracker.com/story/show/146887427, it was found that cwf-d is sending out emails to the actual user's MUSC email, instead of sending to the testing gmail (sparcrequest@gmail.com<mailto:sparcrequest@gmail.com>)..
Please change that setting for cwf-d to use gmail instead (and keep Fulfillment-production sending out emails to the actual user mail).
…________________________________
You can view, comment on, or merge this pull request online at:
#244
Commit Summary
* fix email issue
File Changes
* M app/mailers/task_mailer.rb<https://github.com/sparc-request/sparc-fulfillment/pull/244/files#diff-0> (3)
Patch Links:
* https://github.com/sparc-request/sparc-fulfillment/pull/244.patch
* https://github.com/sparc-request/sparc-fulfillment/pull/244.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#244>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AH7Tzfd76fZMCu28ZBA-ohAJGo1XEQvTks5sirbngaJpZM4PZS3Z>.
-------------------------------------------------------------------------
This message was secured via TLS by MUSC.
|
Stuart-Johnson
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon testing a previous story: https://www.pivotaltracker.com/story/show/146887427, it was found that cwf-d is sending out emails to the actual user's MUSC email, instead of sending to the testing gmail (sparcrequest@gmail.com)..
Please change that setting for cwf-d to use gmail instead (and keep Fulfillment-production sending out emails to the actual user mail).