wth - (SPARCFulfillment) Make the Klok Import Resource Format Rule St… #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtholt
force-pushed
the
wth-klok-import
branch
from
1b91496
to
a7edb9f
Compare
…ricter Please make the importing rule for Klok resource to be stricter, so that the ones do not follow the format of ******(*** ) would error out and also cause the Klok entries to error out and show up in the proof report and import report. Currently, klok/person.rb is extracting NetID from people.name inside the brackets, however, when there are no brackets, the last word of people.name is used as the NetID. That's causing issues because there could be a lot of people with the same last name and we are grabbing the wrong person for fulfillment. [#147196653] Story - https://www.pivotaltracker.com/story/show/147196653
wtholt
force-pushed
the
wth-klok-import
branch
from
a7edb9f
to
7ec091e
Compare
jwiel86
approved these changes
Nov 1, 2017
Stuart-Johnson
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ricter
Please make the importing rule for Klok resource to be stricter, so that the ones do not follow the format of ***( ) would error out and also cause the Klok entries to error out and show up in the proof report and import report.
Currently, klok/person.rb is extracting NetID from people.name inside the brackets, however, when there are no brackets, the last word of people.name is used as the NetID. That's causing issues because there could be a lot of people with the same last name and we are grabbing the wrong person for fulfillment.
[#147196653]
Story - https://www.pivotaltracker.com/story/show/147196653