Jl - Disabling submit button to prevent multiple form submissions #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtholt
approved these changes
Feb 23, 2018
amcates
reviewed
Feb 26, 2018
|
|
||
| $(document).on 'click', '.add_fulfillment', -> | ||
| $('.add_fulfillment').prop('disabled', true) | ||
| $('.fulfillment-form').submit() |
There was a problem hiding this comment.
Do you need this? Won't it continue down the normal submit path?
There was a problem hiding this comment.
Yeah, it will still submit the form. But disabling the button prevents the user from creating multiple fulfillments. Before you could rapid click and create like 6 of them.
There was a problem hiding this comment.
I tried just disabling the button without the $('.fulfillment-form').submit(), but the form would not submit in that case. I needed to do the manual submit after the disable.
This was referenced Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/1304306/stories/145957153