KG - Force WaitHelpers to wait until jQuery loaded on page

[kayla-glick]

Multiple pull requests in SPARC have had randomly failing specs with errors such as jQuery is undefined or $ is undefined. This is because the wait_for_javascript_to_finish helper is being called prior to when jQuery is loaded onto the page. Adding this check should prevent this issue from happening.

[ying-pbrc]

Kyle, I have seen the similar errors in sparc-request/sparc-request pull requests also; can you submit your fix to that repo too? From: Kyle Glick <notifications@github.com> Sent: Thursday, December 06, 2018 2:03 PM To: sparc-request/sparc-fulfillment <sparc-fulfillment@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [sparc-request/sparc-fulfillment] KG - Force WaitHelpers to wait until jQuery loaded on page (#390) Multiple pull requests in SPARC have had randomly failing specs with errors such as jQuery is undefined or $ is undefined. This is because the wait_for_javascript_to_finish helper is being called prior to when jQuery is loaded onto the page. Adding this check should prevent this issue from happening.

…

________________________________ You can view, comment on, or merge this pull request online at: #390 Commit Summary * [#162270805] fix waithelpers File Changes * M spec/support/features/wait_helpers.rb<https://github.com/sparc-request/sparc-fulfillment/pull/390/files#diff-0> (5) Patch Links: * https://github.com/sparc-request/sparc-fulfillment/pull/390.patch * https://github.com/sparc-request/sparc-fulfillment/pull/390.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#390>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHS1u2gIo62x2IUv3HVCmAlD5D9_EMGqks5u2XfcgaJpZM4ZHN_4>.