Merge pull request #304 from sparc-request/jl-remove_step_links

Jl remove step links

app/assets/javascripts/application.js

@@ -43,5 +43,4 @@
 //= require assert
 //= require ajax_handler
 //= require review
-//= require steps
 

app/assets/stylesheets/application.css

@@ -2845,13 +2845,6 @@ table.service_calendar tbody td.visit {
   padding-top: 22px;
 }
 
-.steps_table_link {
-  width: 100%;
-  height: 100%;
-  text-decoration: none;
-  color: #fff;
-}
-
 #service_request_protocol_id {
   width: 300px;
 }

app/controllers/service_requests_controller.rb

@@ -476,10 +476,6 @@ def new_document
     @service_list = @service_request.service_list
   end
 
-  def increment_click_counter
-    ClickCounter.first.increment!(:click_count)
-  end
-
   private
 
   # Send notifications to all users.

app/views/service_requests/_steps.html.haml

@@ -23,60 +23,20 @@
   .test_table
     %table.steps_table{:id => 'steps_banner', :usemap => '#steps_banner'}
       %tr
-        %td
-          - if @service_request.group_valid? :protocol
-            = link_to "javascript:void(0);", :location => 'protocol', :validates => params[:action], :class => 'navigation_link' do
-              .steps_table_link= raw(t(:step_navigation)[:step_1])
-          - else
-            = raw(t(:step_navigation)[:step_1])
-        %td
-          - if @service_request.group_valid?(:service_details, :service_calendar, :service_subsidy)
-            = link_to "javascript:void(0);", :location => 'service_details', :validates => params[:action], :class => 'navigation_link' do
-              .steps_table_link= raw(t(:step_navigation)[:step_2])
-          - else
-            = raw(t(:step_navigation)[:step_2])
-        %td
-          - if @service_request.group_valid? :document_management
-            = link_to "javascript:void(0);", :location => 'document_management', :validates => params[:action], :class => 'navigation_link' do
-              .steps_table_link= raw(t(:step_navigation)[:step_3])
-          - else
-            = raw(t(:step_navigation)[:step_3])
-        %td
-          - if @service_request.group_valid? :document_management
-            = link_to "javascript:void(0);", :location => 'review', :validates => params[:action], :class => 'navigation_link' do
-              .steps_table_link= raw(t(:step_navigation)[:step_4])
-          - else
-            = raw(t(:step_navigation)[:step_4])
+        %td= raw(t(:step_navigation)[:step_1])
+        %td= raw(t(:step_navigation)[:step_2])
+        %td= raw(t(:step_navigation)[:step_3])
+        %td= raw(t(:step_navigation)[:step_4])
         %td= raw(t(:step_navigation)[:step_5])
 .grid_12.col-md-12
   <!--[if !IE 8]> -->
   .test_table
     %table.steps_table{:id => 'steps_banner', :usemap => '#steps_banner'}
       %tr
-        %td
-          - if @service_request.group_valid? :protocol
-            = link_to "javascript:void(0);", :location => 'protocol', :validates => params[:action], :class => 'navigation_link' do
-              .steps_table_link= raw(t(:step_navigation)[:step_1])
-          - else
-            = raw(t(:step_navigation)[:step_1])
-        %td
-          - if @service_request.group_valid?(:service_details, :service_calendar, :service_subsidy)
-            = link_to "javascript:void(0);", :location => 'service_details', :validates => params[:action], :class => 'navigation_link' do
-              .steps_table_link= raw(t(:step_navigation)[:step_2])
-          - else
-            = raw(t(:step_navigation)[:step_2])
-        %td
-          - if @service_request.group_valid? :document_management
-            = link_to "javascript:void(0);", :location => 'document_management', :validates => params[:action], :class => 'navigation_link' do
-              .steps_table_link= raw(t(:step_navigation)[:step_3])
-          - else
-            = raw(t(:step_navigation)[:step_3])
-        %td
-          - if @service_request.group_valid? :document_management
-            = link_to "javascript:void(0);", :location => 'review', :validates => params[:action], :class => 'navigation_link' do
-              .steps_table_link= raw(t(:step_navigation)[:step_4])
-          - else
-            = raw(t(:step_navigation)[:step_4])
+        %td= raw(t(:step_navigation)[:step_1])
+        %td= raw(t(:step_navigation)[:step_2])
+        %td= raw(t(:step_navigation)[:step_3])
+        %td= raw(t(:step_navigation)[:step_4])
         %td= raw(t(:step_navigation)[:step_5])
   <!-- <![endif]-->
 

config/routes.rb

@@ -135,7 +135,6 @@
   match 'service_requests/:id/delete_document/:document_id' => 'service_requests#delete_documents', via: [:all]
   match 'service_requests/:id/edit_document/:document_id' => 'service_requests#edit_documents', via: [:get, :post]
   match 'service_requests/:id/new_document' => 'service_requests#new_document', via: [:get, :post]
-  match 'service_requests/increment_click_counter' => 'service_requests#increment_click_counter', via: [:post]
 
   ##### sparc-services routes brought in and namespaced
   namespace :catalog_manager do

db/migrate/20160229185056_drop_click_counters_table.rb

@@ -0,0 +1,5 @@
+class DropClickCountersTable < ActiveRecord::Migration
+  def change
+    drop_table :click_counters
+  end
+end

db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20160217145001) do
+ActiveRecord::Schema.define(version: 20160229185056) do
 
   create_table "admin_rates", force: :cascade do |t|
     t.integer  "line_item_id", limit: 4
@@ -184,12 +184,6 @@
   add_index "charges", ["service_id"], name: "index_charges_on_service_id", using: :btree
   add_index "charges", ["service_request_id"], name: "index_charges_on_service_request_id", using: :btree
 
-  create_table "click_counters", force: :cascade do |t|
-    t.integer  "click_count", limit: 4
-    t.datetime "created_at",            null: false
-    t.datetime "updated_at",            null: false
-  end
-
   create_table "clinical_providers", force: :cascade do |t|
     t.integer  "identity_id",     limit: 4
     t.integer  "organization_id", limit: 4