wth - (SPARCRequest) Replace FactoryGirl with FactoryBot

https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.md

[#158117921]

Story - https://www.pivotaltracker.com/story/show/158117921

Gemfile

@@ -112,7 +112,7 @@ group :test do
   gem 'capybara-webkit'
   gem 'database_cleaner'
   gem 'email_spec'
-  gem 'factory_girl_rails'
+  gem "factory_bot_rails"
   gem 'rails-controller-testing', require: false
   gem 'rspec-activemodel-mocks'
   gem 'rspec-html-matchers'

Gemfile.lock

@@ -232,10 +232,10 @@ GEM
       actionmailer (>= 4.0, < 6)
       activesupport (>= 4.0, < 6)
     execjs (2.7.0)
-    factory_girl (4.9.0)
+    factory_bot (4.10.0)
       activesupport (>= 3.0.0)
-    factory_girl_rails (4.9.0)
-      factory_girl (~> 4.9.0)
+    factory_bot_rails (4.10.0)
+      factory_bot (~> 4.10.0)
       railties (>= 3.0.0)
     faker (1.8.7)
       i18n (>= 0.7)
@@ -613,7 +613,7 @@ DEPENDENCIES
   equivalent-xml
   exception_notification
   execjs
-  factory_girl_rails
+  factory_bot_rails
   faker
   filterrific!
   gon (~> 6.1)

app/models/survey.rb

@@ -71,12 +71,12 @@ def self.for_dropdown_select
     }
   end
 
-  # Added because version could not be written as an attribute by FactoryGirl. Possible keyword issue?
+  # Added because version could not be written as an attribute by FactoryBot. Possible keyword issue?
   def version=(v)
     write_attribute(:version, v)
   end
 
-  # Added because version could not be read as an attribute by FactoryGirl. Possible keyword issue?
+  # Added because version could not be read as an attribute by FactoryBot. Possible keyword issue?
   def version
     read_attribute(:version)
   end

spec/api/v1/human_subjects_info/get_human_subjects_info_spec.rb

@@ -25,8 +25,8 @@
   describe 'GET /v1/human_subjects_infos/:id.json' do
 
     before do
-      human_subjects_info = FactoryGirl.build(:human_subjects_info, pro_number: nil, hr_number: nil)
-      @study = FactoryGirl.build(:study, human_subjects_info: human_subjects_info)
+      human_subjects_info = FactoryBot.build(:human_subjects_info, pro_number: nil, hr_number: nil)
+      @study = FactoryBot.build(:study, human_subjects_info: human_subjects_info)
       @study.save(validate: false)
 
     end
@@ -65,7 +65,7 @@
 
       it 'should respond with a HumanSubjectsInfo' do
         parsed_body         = JSON.parse(response.body)
-        expected_attributes = FactoryGirl.build(:human_subjects_info).attributes.
+        expected_attributes = FactoryBot.build(:human_subjects_info).attributes.
                                 keys.
                                 reject { |key| ['id','created_at', 'updated_at', 'deleted_at'].include?(key) }.
                                 push('callback_url', 'sparc_id').
@@ -81,7 +81,7 @@
 
       it 'should respond with an array of human_subjects_info and their attributes and their shallow reflections' do
         parsed_body         = JSON.parse(response.body)
-        expected_attributes = FactoryGirl.build(:human_subjects_info).attributes.
+        expected_attributes = FactoryBot.build(:human_subjects_info).attributes.
                                 keys.
                                 reject { |key| ['id', 'created_at', 'updated_at', 'deleted_at'].include?(key) }.
                                 push('callback_url', 'sparc_id', 'protocol').

spec/api/v1/human_subjects_info/get_human_subjects_infos_spec.rb

@@ -26,8 +26,8 @@
 
     before do
       5.times do
-        human_subjects_info = FactoryGirl.build(:human_subjects_info, pro_number: nil, hr_number: nil)
-        @study = FactoryGirl.build(:study, human_subjects_info: human_subjects_info)
+        human_subjects_info = FactoryBot.build(:human_subjects_info, pro_number: nil, hr_number: nil)
+        @study = FactoryBot.build(:study, human_subjects_info: human_subjects_info)
         @study.save(validate: false)
       end
     end
@@ -76,7 +76,7 @@
 
       it 'should respond with an array of human_subjects_info and their attributes' do
         parsed_body         = JSON.parse(response.body)
-        expected_attributes = FactoryGirl.build(:human_subjects_info).attributes.
+        expected_attributes = FactoryBot.build(:human_subjects_info).attributes.
                                 keys.
                                 reject { |key| ['id', 'created_at', 'updated_at', 'deleted_at'].include?(key) }.
                                 push('callback_url', 'sparc_id').
@@ -92,7 +92,7 @@
 
       it 'should respond with an array of human_subjects_info and their attributes and their shallow reflections' do
         parsed_body         = JSON.parse(response.body)
-        expected_attributes = FactoryGirl.build(:human_subjects_info).attributes.
+        expected_attributes = FactoryBot.build(:human_subjects_info).attributes.
                                 keys.
                                 reject { |key| ['id', 'created_at', 'updated_at', 'deleted_at'].include?(key) }.
                                 push('callback_url', 'sparc_id', 'protocol').

spec/api/v1/human_subjects_info/get_human_subjects_infos_with_ids_spec.rb

@@ -27,8 +27,8 @@
 
     before do
       5.times do
-        human_subjects_info = FactoryGirl.build(:human_subjects_info, pro_number: nil, hr_number: nil)
-        @study = FactoryGirl.build(:study, human_subjects_info: human_subjects_info)
+        human_subjects_info = FactoryBot.build(:human_subjects_info, pro_number: nil, hr_number: nil)
+        @study = FactoryBot.build(:study, human_subjects_info: human_subjects_info)
         @study.save(validate: false)
       end
 
@@ -79,7 +79,7 @@
       it 'should respond with an array of human_subjects_info and their attributes' do
         parsed_body         = JSON.parse(response.body)
 
-        expected_attributes = FactoryGirl.build(:human_subjects_info).attributes.
+        expected_attributes = FactoryBot.build(:human_subjects_info).attributes.
                                 keys.
                                 reject { |key| ['id', 'created_at', 'updated_at', 'deleted_at'].include?(key) }.
                                 push('callback_url', 'sparc_id').
@@ -95,7 +95,7 @@
 
       it 'should respond with an array of human_subjects_info and their attributes and their shallow reflections' do
         parsed_body         = JSON.parse(response.body)
-        expected_attributes = FactoryGirl.build(:human_subjects_info).attributes.
+        expected_attributes = FactoryBot.build(:human_subjects_info).attributes.
                                 keys.
                                 reject { |key| ['id', 'created_at', 'updated_at', 'deleted_at'].include?(key) }.
                                 push('callback_url', 'sparc_id', 'protocol').

spec/api/v1/identities/get_identity_by_ldap_uid_spec.rb

@@ -24,7 +24,7 @@
 
   describe 'GET /v1/identities.json' do
     before do
-      FactoryGirl.create_list(:identity, 5)
+      FactoryBot.create_list(:identity, 5)
     end
     ##################################
     # Shallow records
@@ -801,9 +801,9 @@
         before do
           @identity = Identity.first
           5.times do
-            protocol = FactoryGirl.build(:protocol)
+            protocol = FactoryBot.build(:protocol)
             protocol.save validate: false
-            FactoryGirl.create(:project_role_with_identity_and_protocol, identity: @identity, protocol: protocol)
+            FactoryBot.create(:project_role_with_identity_and_protocol, identity: @identity, protocol: protocol)
           end
 
           params = { :depth => 'full_with_shallow_reflections',
@@ -831,9 +831,9 @@
         before do
           @identity = Identity.first
           5.times do
-            protocol = FactoryGirl.build(:protocol)
+            protocol = FactoryBot.build(:protocol)
             protocol.save validate: false
-            FactoryGirl.create(:project_role_with_identity_and_protocol, identity: @identity, protocol: protocol)
+            FactoryBot.create(:project_role_with_identity_and_protocol, identity: @identity, protocol: protocol)
           end
 
           params = { :depth => 'full_with_shallow_reflections',
@@ -863,9 +863,9 @@
         before do
           @identity = Identity.first
           5.times do
-            protocol = FactoryGirl.build(:protocol)
+            protocol = FactoryBot.build(:protocol)
             protocol.save validate: false
-            FactoryGirl.create(:project_role_with_identity_and_protocol, identity: @identity, protocol: protocol)
+            FactoryBot.create(:project_role_with_identity_and_protocol, identity: @identity, protocol: protocol)
           end
 
           params = { :depth => 'full_with_shallow_reflections',
@@ -895,9 +895,9 @@
         before do
           @identity = Identity.first
           5.times do
-            protocol = FactoryGirl.build(:protocol)
+            protocol = FactoryBot.build(:protocol)
             protocol.save validate: false
-            FactoryGirl.create(:project_role_with_identity_and_protocol, identity: @identity, protocol: protocol)
+            FactoryBot.create(:project_role_with_identity_and_protocol, identity: @identity, protocol: protocol)
           end
           # update all identities to have the same institution
           Identity.all.each do |identity|

spec/controllers/catalog_manager/services_controller_spec.rb

@@ -75,7 +75,7 @@
 
       context "Service has pre-existing ServiceLevelComponents" do
 
-        before { @service = FactoryGirl.create(:service_with_components) }
+        before { @service = FactoryBot.create(:service_with_components) }
 
         it "should create new ServiceLevelComponents" do
           put :update, params: { id: @service.id, service: { name: "New name" }.merge!(service_level_component_params) }
@@ -98,7 +98,7 @@
       context "Service with pre-existing ServiceLevelComponents" do
 
         it "should build ServiceLevelComponents with the correct :position" do
-          service = FactoryGirl.create(:service_with_components, organization: organization)
+          service = FactoryBot.create(:service_with_components, organization: organization)
 
           get :show, params: { id: service.id }
 

spec/extensions/epic_interface_spec.rb

@@ -1192,7 +1192,7 @@ def strip_xml_whitespace!(root)
     end
 
     it 'should send an arm as a cell' do
-      FactoryGirl.create(:service_request_without_validations,
+      FactoryBot.create(:service_request_without_validations,
                                             protocol: study,
                                             status: 'draft')
 
@@ -1273,7 +1273,7 @@ def strip_xml_whitespace!(root)
     end
 
     it 'should send two arms as two cells' do
-      FactoryGirl.create(:service_request_without_validations,
+      FactoryBot.create(:service_request_without_validations,
                                             protocol: study,
                                             status: 'draft')
 
@@ -1405,7 +1405,7 @@ def strip_xml_whitespace!(root)
     context 'with line items' do
 
       let!(:service_request) {
-        FactoryGirl.create(:service_request_without_validations,
+        FactoryBot.create(:service_request_without_validations,
                             protocol: study,
                             status: 'submitted')
       }

spec/factories/admin_rate.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :admin_rate do
 

spec/factories/affiliation.rb

@@ -20,7 +20,7 @@
 
 # The association with protocol must be created manually through the id's
 # due to validations on protocol
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :affiliation do
     name                 { Faker::Lorem.word }

spec/factories/approval.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :approval do
     approval_date      { Time.now }

spec/factories/arm.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :arm do
     sequence(:name)       { |n| "Arm #{n}" }
     subject_count         { 1 }

spec/factories/associated_survey.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :associated_survey do
     survey      { nil }
     associable  { nil }

spec/factories/available_status.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :available_status do
     selected true

spec/factories/catalog_manager.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :catalog_manager do
     edit_historic_data { false } 

spec/factories/charge.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :charge do
     charge_amount      { Random.rand(1000) }

spec/factories/clinical_provider.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :clinical_provider do
     identity nil

spec/factories/contact_form.rb

@@ -18,10 +18,10 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR~
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.~
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :contact_form, class: ContactForm do
     subject 'SPARC-Request'
     email 'example@example.com'
     message 'this is a sample message'
   end
-end
+end

spec/factories/document.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :document do
     doc_type             { 'other' }
     doc_type_other       { Faker::Lorem.word }

spec/factories/editable_status.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :editable_status do
     selected true
     status { PermissibleValue.get_key_list('status').sample }

spec/factories/epic_queue.rb

@@ -18,9 +18,9 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :epic_queue, aliases: [:eq] do
     created_at   { Time.now }
     updated_at   { Time.now }
   end
-end
+end

spec/factories/epic_queue_record.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR~
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.~
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :epic_queue_record do
     protocol_id nil
     status 'complete'

spec/factories/excluded_funding_source.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :excluded_funding_source do
   end

spec/factories/feedback.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR~
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.~
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :feedback do
     letters Digest::SHA1.hexdigest(Time.now.usec.to_s)[0..16]
     name 'name'

spec/factories/form.rb

@@ -18,7 +18,7 @@
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :form do
     title                     { Faker::Lorem.word }
     access_code               { Faker::Lorem.word }