Merge pull request #2079 from sparc-request/admin-edit-surveys-header…

…-fix

Hide Surveys column in Admin Edit if the ssr doesn't have any available surveys

app/models/sub_service_request.rb

@@ -426,8 +426,6 @@ def all_forms_completed?
   # Distributes all available surveys to primary pi and ssr requester
   def distribute_surveys
     primary_pi = protocol.primary_principal_investigator
-    # send all available surveys at once
-    available_surveys = line_items.map{|li| li.service.available_surveys}.flatten.compact.uniq
     # do nothing if we don't have any available surveys
     unless available_surveys.empty?
       SurveyNotification.service_survey(available_surveys, primary_pi, self).deliver
@@ -437,6 +435,11 @@ def distribute_surveys
       end
     end
   end
+
+  # send all available surveys at once
+  def available_surveys
+    self.line_items.map{|li| li.service.available_surveys}.flatten.compact.uniq
+  end
 
   def surveys_completed?
     self.line_items.

app/views/dashboard/sub_service_requests/_header.html.haml

@@ -49,7 +49,7 @@
             - unless request_valid
               = icon('fas', 'exclamation-circle text-warning mr-1')
             = t('dashboard.sub_service_requests.header.fulfillment.header')
-        - if sub_service_request.is_complete?
+        - if sub_service_request.is_complete? && !sub_service_request.available_surveys.empty?
           %th.text-center
             = t('dashboard.sub_service_requests.header.surveys.header')
         %th.text-center
@@ -88,7 +88,7 @@
         - if use_fulfillment
           %td.text-center#fulfillmentStatusContainer{ title: request_valid ? '' : t('dashboard.sub_service_requests.tooltips.request_invalid'), data: { toggle: 'tooltip' } }
             = ready_for_fulfillment_display(sub_service_request, request_valid)
-        - if sub_service_request.is_complete?
+        - if sub_service_request.is_complete? && !sub_service_request.available_surveys.empty?
           %td.text-center#surveys
             = resend_surveys_ssr_button(sub_service_request)
         %td.text-center#effectiveCost