Merge pull request #184 from sparc-request/jw_sparc_id_in_subject_line

added protocol id to subject line of service provider emails.  Also a…

app/mailers/notifier.rb

@@ -113,7 +113,7 @@ def notify_service_provider service_provider, service_request, attachments_to_ad
 
     # only send these to the correct person in the production env
     email = Rails.env == 'production' ? service_provider.identity.email : DEFAULT_MAIL_TO
-    subject = Rails.env == 'production' ? "#{I18n.t('application_title')} service request" : "[#{Rails.env.capitalize} - EMAIL TO #{service_provider.identity.email}] #{I18n.t('application_title')} service request"
+    subject = Rails.env == 'production' ? "#{@protocol.id} - #{I18n.t('application_title')} service request" : "#{@protocol.id} - [#{Rails.env.capitalize} - EMAIL TO #{service_provider.identity.email}] #{I18n.t('application_title')} service request"
 
     mail(:to => email, :from => NO_REPLY_FROM, :subject => subject)
   end

spec/mailers/notifier_spec.rb

@@ -187,6 +187,9 @@
           expect(mail).to have_xpath("//th[text()='Service']/following-sibling::th[text()='Action']")
           expect(mail).to have_xpath("//td[text()='#{service.name}']/following-sibling::td[text()='Removed']")
         end
+        it "should have the correct subject" do
+          expect(mail).to have_subject("#{service_request.protocol.id} - [Test - EMAIL TO glennj@musc.edu] SPARC Request service request")
+        end
       end
     end