SAW - Another PermissibleValue method #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcates
reviewed
Jul 14, 2017
| @@ -10,8 +10,13 @@ def self.get_value_list(category) | |||
| PermissibleValue.where(category: category).pluck(:value) | |||
| end | |||
|
|
|||
| # Get a hash of PermissibleValue keys as they keys and values as values | |||
| def self.get_hash(category) | |||
There was a problem hiding this comment.
What is the difference between this method and the one below? They do the same thing
There was a problem hiding this comment.
#get_hash uses the standard format { key => value } but #get_value_key_hash uses a { value => key } format
There was a problem hiding this comment.
yes, and I was confused because they looked so similar.
kayla-glick
approved these changes
Jul 14, 2017
Stuart-Johnson
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#147708807
This method gets a hash of PermissibleValue keys as the keys and values as the values (what you would expect)