KG/JM - (Production Bug) A NoMethodError occurred in protocols#new [#… #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiel86
force-pushed
the
jm-authorize-identity-production-bug
branch
from
8f40566
to
4b46243
Compare
kayla-glick
reviewed
Jul 24, 2017
| @@ -188,7 +188,7 @@ def authorize_identity | |||
| return true | |||
| end | |||
| # the service request is in first draft and has yet to be submitted (catalog page only) | |||
| elsif @service_request.status == 'first_draft' | |||
| elsif @service_request.status == 'first_draft' && controller_name == 'service_requests' && action_name == 'catalog' | |||
There was a problem hiding this comment.
For anyone curious, the reason this didn't work is because a @service_request.status could be first_draft in the catalog (homepage), protocol page (step 1), or creating a new protocol in proper. The old code would allow a user to access both step 1 and the new protocol form without logging in. Step 1 wasn't causing any issues from what I can tell, but the new protocol form broke because it called current_user.
Now, users are limited to the homepage without logging in.
kayla-glick
approved these changes
Jul 24, 2017
Stuart-Johnson
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…148823111] https://www.pivotaltracker.com/story/show/148823111