KG - Step 2B: Calendar Query and Rendering Need Improvement Part 3 - Initial Load #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 14, 2017 10:01
Stuart-Johnson
approved these changes
Jul 26, 2017
kayla-glick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal:
https://www.pivotaltracker.com/story/show/147048549
Focuses on optimizing the PPPV and OTF Calendar views using eager loading, as well as using a few refactors (particularly to the OTF line items). Once finished, I looked back at the eager loading used in the other parts of the calendar optimization to clean them up. In several places, there was extra being eager loaded that was actually slowing down the load time.
Note: This PR includes the changes made in #997. I would recommend waiting until it's merged to review this.