JM/KG - (Production Bug): An Icalendar::Values::Date::FormatError occurr… #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
approved these changes
Jul 25, 2017
kayla-glick
suggested changes
Jul 25, 2017
| @@ -426,6 +426,7 @@ def setup_catalog_calendar | |||
| active_alert.save | |||
| ExceptionNotifier::Notifier.exception_notification(request.env, e).deliver unless request.remote_ip == '128.23.150.107' # this is an ignored IP address, MUSC security causes issues when they pressure test, this should be extracted/configurable | |||
| end | |||
| rescue ArgumentError | |||
There was a problem hiding this comment.
ArgumentError should probably be handled by the previous rescue block so that we will receive notifications for it.
rescue Exception, ArgumentError => e
…ed in service_requests#catalog [#148701413] https://www.pivotaltracker.com/story/show/148701413
jwiel86
force-pushed
the
jm-production-format-error
branch
from
b45fcca
to
3aca4d2
Compare
kayla-glick
approved these changes
Jul 26, 2017
Stuart-Johnson
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed in service_requests#catalog [#148701413] https://www.pivotaltracker.com/story/show/148701413