KG - ServiceRequestController#remove_service #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 27, 2017 13:57
…to kg-remove_service_bug
kayla-glick
commented
Jul 27, 2017
| @@ -188,7 +188,7 @@ def authorize_identity | |||
| return true | |||
| end | |||
| # the service request is in first draft and has yet to be submitted (catalog page only) | |||
| elsif @service_request.status == 'first_draft' && controller_name == 'service_requests' && action_name == 'catalog' | |||
| elsif @service_request.status == 'first_draft' && controller_name != 'protocols' && action_name != 'protocol' | |||
There was a problem hiding this comment.
Merged from #1029 to be able to test
Stuart-Johnson
approved these changes
Aug 2, 2017
jwiel86
reviewed
Aug 3, 2017
| notifier_logic.ssr_deletion_emails(ssr, ssr_destroyed: true, request_amendment: false) | ||
| ssr.destroy | ||
| if ssr.line_items.any? | ||
| ssr.update_attribute(:status, 'draft') unless ssr.status == 'first_draft' |
There was a problem hiding this comment.
@kyle-glick Get with me when you're back in town about lines 215-216. This impacts how emails are sent out. I'll explain further in person :)
added 2 commits
August 14, 2017 10:46
jwiel86
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal:
https://www.pivotaltracker.com/story/show/149644637