KG - Step 2B: Calendar Query and Rendering Need Improvement Part 3 - Initial Load #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
July 14, 2017 10:01
kayla-glick
commented
Jul 28, 2017
| @@ -105,7 +105,7 @@ def show_move_visits | |||
| @consolidated = params[:consolidated] | |||
| @merged = params[:merged] | |||
| @statuses_hidden = params[:statuses_hidden] | |||
| @arm = Arm.eager_load(:visit_groups).find( params[:arm_id] ) | |||
| @arm = Arm.find( params[:arm_id] ) | |||
There was a problem hiding this comment.
Bug: Eager load prevented the move visits visit groups from ordering by position
jwiel86
approved these changes
Jul 28, 2017
kayla-glick
commented
Jul 28, 2017
| @@ -19,6 +19,7 @@ | |||
| -# TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
| .modal-dialog.modal-md | |||
| .modal-content | |||
| = hidden_field_tag :arm_id, arm.id | |||
There was a problem hiding this comment.
Bug: arm_id was not being found by javascript when changing the selected visit
kayla-glick
commented
Jul 28, 2017
| @@ -22,6 +22,6 @@ $("#modal_place #modal_errors").html("<%= escape_javascript(render( 'shared/moda | |||
| <% else %> | |||
| $('.visit-group-<%=@visit_group.id%>:visible').replaceWith("<%= j render 'service_calendars/master_calendar/pppv/visit_group', visit_group: @visit_group, tab: params[:tab], page: @page, pages: @pages, portal: @portal, review: @review, admin: @admin, merged: @merged, consolidated: @consolidated, statuses_hidden: params[:statuses_hidden] %>") | |||
| $('.visit-group-select:visible').html("<%= j render 'service_calendars/master_calendar/pppv/visit_group_page_select', service_request: @service_request, sub_service_request: @sub_service_request, arm: @visit_group.arm, tab: params[:tab], page: @page, pages: @pages, portal: @portal, review: @review, admin: @admin, merged: @merged, consolidated: @consolidated, statuses_hidden: params[:statuses_hidden] %>") | |||
| $('#visits-select-for-<%=@visit_group.arm_id%>').selectpicker() | |||
| $('#visits-select-for-<%=@visit_group.arm_id%>.selectpicker').selectpicker() | |||
There was a problem hiding this comment.
Bug: Selector was not finding the select for some reason. @jwiel86 and I looked into this and could not figure out why. Adding .selectpicker seemed to fix it for some reason. Again, don't really understand why...
wtholt
approved these changes
Aug 2, 2017
Stuart-Johnson
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal:
https://www.pivotaltracker.com/story/show/147048549
Focusing on optimizing the PPPV and OTF calendars through a mix of eager loading and refactors.
Note: Reopened after removing refactor code of the previous parts of this story to make review easier. Will post those changes in another PR after this is approved and merged.