KG - More OS Settings Configurations Updates #1041
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
defaults.json
and updated as much data as I could.defaults.json
instead ofapplication.yml
.application.yml
constants initializers.STILL TODO:
try
s to all value calls to prevent crashes? May also not want to do this so that we will receive the error and know that the setting is not defined.Note: Please review the
defaults.json
changes. Focus on language of friendly name and description, and the parent associations. Please make comments with recommended changes.Note 2: Specs are expected to fail right now. The base branch
os-move-configuration-to-database
is failing. This is something we need to look into.