Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KG - More OS Settings Configurations Updates #1041

Conversation

kayla-glick
Copy link
Contributor

@kayla-glick kayla-glick commented Jul 31, 2017

Changes:

  1. Added any missing constants to defaults.json and updated as much data as I could.
  2. Changed the temporary rake task to use defaults.json instead of application.yml.
  3. Fix several constant calls still remaining within the application.
  4. Removed several unused consants.
  5. Removed application.yml constants initializers.

STILL TODO:

  • Add trys to all value calls to prevent crashes? May also not want to do this so that we will receive the error and know that the setting is not defined.
  • Move data change from task to the migration
  • Update application documentation to reflect new configuration
  • Move other configurations to database? - epic.yml, ldap.yml, travis.yml, database.yml

Note: Please review the defaults.json changes. Focus on language of friendly name and description, and the parent associations. Please make comments with recommended changes.

Note 2: Specs are expected to fail right now. The base branch os-move-configuration-to-database is failing. This is something we need to look into.

@kayla-glick kayla-glick changed the title KG - More Settings Updates KG - More OS Settings Configurations Updates Jul 31, 2017
@Stuart-Johnson Stuart-Johnson merged commit 7d9b7a3 into os-move-configuration-to-database Aug 14, 2017
@Stuart-Johnson Stuart-Johnson deleted the os-settings_data_reconfiguration branch August 14, 2017 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants