wth - Milestones touchups #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please remove the "Study/ Project" wording from the Dates, to keep consistency with the corresponding labels on SPARCRequest Step 2 page. (sorry, my original mockup forgot the consistency with 2 of the labels...) Please include a space between Service Requests table and Milestone table, currently they look right adjacent to each other; Is there a way to make the date fields update real-time, instead of using the "Update Milestones" button? That could decrease the chance of losing data. [#149694407] Story - https://www.pivotaltracker.com/story/show/149694407
kayla-glick
suggested changes
Aug 15, 2017
| @@ -25,7 +25,7 @@ | |||
| = render 'dashboard/service_requests/service_requests', protocol: @protocol, super_user_orgs: @super_user_orgs, permission_to_edit: @permission_to_edit, user: @user, view_only: false, show_view_ssr_back: @show_view_ssr_back, statuses_hidden: %(first_draft) | |||
| .additional-details-submissions-panel | |||
| = render "additional_details/submissions/submissions_panel", protocol: @protocol, submissions: @submissions | |||
| .milestones-panel | |||
| .milestones-panel.spacing-above | |||
There was a problem hiding this comment.
Instead of adding a class to do this, moving the panel and panel-default div to this would do the same thing, using the built-in bootstrap panel-group styling.
.milestones-panel.panel.panel-default
____= render "dashboard/protocols/milestone", protocol: @protocol
There was a problem hiding this comment.
@kyle-glick I tried that, but it didn't add the spacing.
Stuart-Johnson
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remove the "Study/ Project" wording from the Dates, to keep consistency with the corresponding labels on SPARCRequest Step 2 page. (sorry, my original mockup forgot the consistency with 2 of the labels...)
Please include a space between Service Requests table and Milestone table, currently they look right adjacent to each other;
Is there a way to make the date fields update real-time, instead of using the "Update Milestones" button? That could decrease the chance of losing data.
[#149694407]
Story - https://www.pivotaltracker.com/story/show/149694407