KG - Pending Responses / Response Errors #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st/sparc-request into kg-pending_responses
Stuart-Johnson
approved these changes
Aug 17, 2017
marklohr
approved these changes
Aug 17, 2017
jwiel86
approved these changes
Aug 17, 2017
SamWord
approved these changes
Aug 17, 2017
wtholt
approved these changes
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial Story: https://www.pivotaltracker.com/story/show/150225100
Also inadvertently fixed https://www.pivotaltracker.com/story/show/150270022
Wenjun has requested the ability to track surveys as pending/completed for reporting purposes. The current controller setup did not allow this, because survey responses were not actually created until the user took the survey. Instead, when taking a survey from the service survey emails, we can create a blank response, and the user edits that blank response to fill out the survey. Thus instead of using #new and #create, they use #edit and #update.