KG - Editable Status Bug #1082
Merged
KG - Editable Status Bug #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/150407042
Issue:
first_draftis not shown to users under available statuses or editable statuses. What was happening is thatfirst_drafteditable statuses were not being saved when updating an organization because we were not creating inputs for them (which would have had to be hidden on the page all the time).Solution:
At first I considered making 'first_draft' just a hidden checkbox, but instead of doing that, I decided that moving the check
self.status == 'first_draft'intosub_service_request.rb#can_be_edited?was a simpler method. This prevents the various<< 'first_draft'calls to addfirst_draftas an editable status. Also becausefirst_draftis not technically an available status, havingfirst_drafteditable status goes against how the editable statuses are supposed to be shown.