identity_id & unit_factor issue #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
approved these changes
Aug 29, 2017
added 2 commits
August 30, 2017 09:06
|
I updated the pull request to include just the fixes for the identity_id and unit. |
kayla-glick
reviewed
Sep 1, 2017
| @@ -32,7 +32,7 @@ def associate_with_org_unit | |||
| identity = Identity.find identity_id | |||
|
|
|||
| if rel_type == 'service_provider_organizational_unit' | |||
| if not oe.service_providers or (oe.service_providers and not oe.service_providers.map(&:id).include? identity_id) | |||
| if not oe.service_providers or (oe.service_providers and not oe.service_providers.map(&:identity_id).include? identity_id) | |||
There was a problem hiding this comment.
This is minor, but for efficiency, pluck(:identity_id) would be much more efficient since #map requires the objects to be returned from the database
There was a problem hiding this comment.
Yes. I changed map to pluck. and committed the changes
added 2 commits
September 5, 2017 12:33
|
It is |
jleonardw9
approved these changes
Sep 19, 2017
jwiel86
approved these changes
Sep 19, 2017
marklohr
approved these changes
Sep 28, 2017
Stuart-Johnson
approved these changes
Oct 4, 2017
wtholt
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the branch to v3.0.0 and recreated the pull request