JM/WTH - (SPARCDashboard) Admin Edit DateTimePicker Bug [#151329978] #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
reviewed
Sep 25, 2017
app/models/sub_service_request.rb
Outdated
| end | ||
|
|
||
| def requester_contacted_date=(date) | ||
| write_attribute(:requester_contacted_date, Time.strptime(date, "%m/%d/%Y")) if date.present? | ||
| date.present? ? write_attribute(:requester_contacted_date, Time.strptime(date, "%m/%d/%Y")) : write_attribute(:requester_contacted_date, nil) |
There was a problem hiding this comment.
These might be able to be condensed just a little bit by moving the ternary.
write_attribute(:requester_contacted_date, date.present? ? Time.strptime(date, "%m/%d/%Y") : nil)
jwiel86
force-pushed
the
jm-wh-admin-edit-date-bug
branch
from
7df7470
to
a9d5e6e
Compare
Stuart-Johnson
approved these changes
Sep 26, 2017
marklohr
approved these changes
Sep 28, 2017
jleonardw9
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/151329978