JM- (SPARCRequest) Email "Requester" Column Feature [#151517872] #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
suggested changes
Oct 20, 2017
app/models/sub_service_request.rb
Outdated
| @@ -62,6 +62,10 @@ def consult_arranged_date=(date) | |||
| write_attribute(:consult_arranged_date, date.present? ? Time.strptime(date, "%m/%d/%Y") : nil) | |||
| end | |||
|
|
|||
| def display_service_requester_name | |||
There was a problem hiding this comment.
If service requester is an identity, then we can do something equivalent using ssr.service_requester.full_name
| %tbody | ||
| - @ssrs_to_be_displayed.each do |ssr| | ||
| %tr.skinny-black-border | ||
| %td.skinny-black-border.center | ||
| %strike= ssr.display_id | ||
| %td.skinny-black-border.center | ||
| %strike= ssr.org_tree_display | ||
| %td.skinny-black-border.center | ||
| %strike= ssr.display_service_requester_name |
There was a problem hiding this comment.
ssr.service_requester.try(&:full_name) || 'N/A'
| @@ -38,5 +39,6 @@ | |||
| %td.skinny-black-border.center= ssr.display_id | |||
| %td.skinny-black-border.center= ssr.org_tree_display | |||
| %td.skinny-black-border.center= PermissibleValue.get_value('status', ssr.reload.status) | |||
| %td.skinny-black-border.center= ssr.display_service_requester_name | |||
There was a problem hiding this comment.
ssr.service_request.try(&:full_name) || 'N/A'
jwiel86
force-pushed
the
jm-email-requester-bug
branch
2 times, most recently
from
b9ec986
to
1f4e282
Compare
kayla-glick
approved these changes
Oct 23, 2017
jwiel86
force-pushed
the
jm-email-requester-bug
branch
from
1f4e282
to
d7a31f0
Compare
marklohr
approved these changes
Nov 1, 2017
Stuart-Johnson
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/151517872