JM - (Production Bug)A NoMethodError occurred in protocols#create [#1… #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtholt
approved these changes
Oct 26, 2017
kayla-glick
suggested changes
Oct 27, 2017
| @@ -322,8 +322,10 @@ def convert_date_for_save(attrs, date_field) | |||
| def fix_identity | |||
| attrs = protocol_params | |||
| attrs[:project_roles_attributes].each do |index, project_role| | |||
| identity = Identity.find_or_create project_role[:identity_id] | |||
| project_role[:identity_id] = identity.id | |||
| if project_role[:identity_id].present? | |||
There was a problem hiding this comment.
I noticed this exact code is also in Dashboard::ProtocolsController.rb. This change probably needs to happen there as well.
kayla-glick
approved these changes
Oct 30, 2017
Stuart-Johnson
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…52288500]
If testing manually, please see the story. There are steps to reproduce. Thanks!