JM- (SPARCRequest & SPARCDashboard) Duplicate Study Types found in Pr… #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otocol 11472 [#152547633]
wtholt
approved these changes
Nov 6, 2017
kayla-glick
approved these changes
Nov 8, 2017
Stuart-Johnson
approved these changes
Nov 17, 2017
Stuart-Johnson
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…otocol 11472 [#152547633]
https://www.pivotaltracker.com/story/show/152547633
Production Bug (#152403697) led to the discovery of bad data.
See screenshots below.
In Dashboard --> View Study Details, you can see under "Study Types" that "Basic Science" is displayed twice. This is also shown in the database.
Figure out how this was able to happen in the first place.
UPDATE:
Andrew mentioned that he'd seen this happen before when users would click multiple times on the Submit button. I tested this theory in Dashboard --> Edit Study and Proper --> Edit Study and he was correct.
I've fixed it so that after the first click, the button is disabled and "Saving..." appears as the button text along with a disabled icon next to the mouse. This should prevent bad data from being saved.