SJ - Fixing indirect cost validation [#152641470] #1184
Conversation
|
@Stuart-Johnson Looks good, but I think you can git checkout those db/schema.rb changes. |
spec/models/protocol/valid?_spec.rb
Outdated
| @@ -38,6 +38,8 @@ | |||
| end | |||
| end | |||
|
|
|||
| it { is_expected.to validate_numericality_of(:indirect_cost_rate).is_greater_than_or_equal_to(1) } | |||
| it { is_expected.to validate_numericality_of(:indirect_cost_rate).is_less_than_or_equal_to(1000) } | |||
| if Setting.find_by_key('use_indirect_cost').value | |||
There was a problem hiding this comment.
After discussing with @Stuart-Johnson, we should not use an if condition here, but instead a before :each do block where use_indirect_cost is turned on.
before :each do
stub_config("use_indirect_cost", true)
end
|
Like @wtholt said and after discussing with @Stuart-Johnson, it seems like the schema changes should be checked out, though we may want to consider the effect of the inconsistent collation in the schema file. Is it a big deal or does it need to be updated? Schema does update itself automatically,but it only updates the information for specific tables being changed in migrations, so because a lot of older tables have not be changed in a while, the collation may be out-of-date. |
https://www.pivotaltracker.com/story/show/152641470