wth - (SPARC-code) Migrate piwik_tracking.html.haml into Settings Table #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on discussion with Andrew, we've decided to rename the Piwik file to be named generically 'shared/_analytics.html.haml' and to just include an empty file on the public repo, so that OS institutions can include their own version of analytics tracking to their projects. On our production instance, we will symlink our file to use Piwik. [#152608619] Story - https://www.pivotaltracker.com/story/show/152608619
marklohr
approved these changes
Dec 7, 2017
jleonardw9
approved these changes
Dec 8, 2017
Stuart-Johnson
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion with Andrew, we've decided to rename the Piwik file
to be named generically 'shared/_analytics.html.haml' and to just
include an empty file on the public repo, so that OS institutions can
include their own version of analytics tracking to their projects. On
our production instance, we will symlink our file to use Piwik.
[#152608619]
Story - https://www.pivotaltracker.com/story/show/152608619