Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wth - (SPARCRequest) Step 6: Adjust Table Display for Consistency #1223

Merged
merged 1 commit into from Jan 29, 2018

Conversation

wtholt
Copy link
Contributor

@wtholt wtholt commented Jan 17, 2018

Background: Currently, on SPARCRequest Step 6 (Review Your Request), the sequence of the tables displayed doesn't follow the steps, and the Forms table (when form functionality is activated) is not present for users to review the form-related info.

Please:
1). Adjust the sequence of the displayed tables on SPARCRequest Step 6, so that the "Clinical Services", "Non-clinical Services", and "Total Costs" table shows up before the "Documents" table.

2). Add the "Forms" table (with viewing function) to below the "Notes" table, for user to get a whole view of the protocol/request.

[#153994564]

Story - https://www.pivotaltracker.com/story/show/153994564

Background: Currently, on SPARCRequest Step 6 (Review Your Request), the sequence of the tables displayed doesn't follow the steps, and the Forms table (when form functionality is activated) is not present for users to review the form-related info.

Please:
1). Adjust the sequence of the displayed tables on SPARCRequest Step 6, so that the "Clinical Services", "Non-clinical Services", and "Total Costs" table shows up before the "Documents" table.

2). Add the "Forms" table (with viewing function) to below the "Notes" table, for user to get a whole view of the protocol/request.

[#153994564]

Story - https://www.pivotaltracker.com/story/show/153994564
Copy link
Contributor

@kayla-glick kayla-glick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to Wenjun about this since it somewhat conflicts with the Survey/Form merge. If this is not an urgent story, would it be better to combine this story with the merge story?

@Stuart-Johnson Stuart-Johnson dismissed kayla-glick’s stale review January 29, 2018 15:59

I think the proper way to handle this is just to update your Survey/Form branch from master, and fix issues as needed.

@Stuart-Johnson Stuart-Johnson merged commit bfe4330 into master Jan 29, 2018
@Stuart-Johnson Stuart-Johnson deleted the wth-adjust-table-display branch January 29, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants