KG - Survey/Form Builder Merge #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rc-request/sparc-request into kg-survey_form_builder_merge
…rc-request/sparc-request into kg-survey_form_builder_merge
added 7 commits
February 13, 2018 13:34
…omly failing the spec
kayla-glick
requested review from
amcates,
Stuart-Johnson,
jleonardw9,
jwiel86,
wtholt,
marklohr,
shbz1690,
SamWord and
BigChiefSmidgeums
jwiel86
approved these changes
Feb 26, 2018
wtholt
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Pivotal Story:
https://www.pivotaltracker.com/story/show/151232661
Related Bug Stories:
https://www.pivotaltracker.com/story/show/154739723
https://www.pivotaltracker.com/story/show/154743223
Note: This is a massive story due to the back-end refactors that had to be made to make this branch stable. Please thoroughly test each component listed below. There are extensive specs for this, but specs can't always find every little bug.
Note 2: For testing, you will have to run migrations. This will cause issues if you need to do something on another branch and will require you to re-import your data. Sorry in advance!
Note 3: We are aware that if you edit a Form after having responded to it then the Response becomes inconsistent with the Form. This story https://www.pivotaltracker.com/story/show/155199579 will resolve that case.
Description
This story combines Surveys and Questionnaires into a polymorphic model. We have Surveys with types
SystemSurveyandForm.SystemSurveys are the same as the old Surveys, used for the System Satisfaction Survey and sent out via survey emails upon SSR completion.Forms are the equivalent of Questionnaires. However, their workflow has been changed significantly.This story moves the form builder onto the same page as the survey builder. This page can be accessed temporarily via button in SPARCCatalog (See image 1).
On the survey builder page, only Site Admins can access the SystemSurvey table, while only Super Users, Service Providers, and Catalog Overlords can access the Form table (See images 2, 3 and 4). Super Users and Service Providers can only access forms for organization and services they have admin rights to. Catalog Overlords can access all forms.
Creating a Form uses the same process as SystemSurveys with one addition. The user must search for an Organization or Service to attach the Form to (See image 5). Once a form is created, the forms will appear on ServiceRequests using SubServiceRequests for those Organizations and Services. These forms can be filled out on the Documents, Notes, and Forms page of SPARC Proper, or in the Dashboard (See images 6 and 7).
The Proper/Dashboard functionality remains the same, though some improvements were made to it for consistency. For example, the tables were made into JSON-populating Bootstrap Tables.
Image 1 - Accessing the Builder
Image 2 - Survey/Form Builder Screen, Site Admin Only
Image 3 - Survey/Form Builder Screen, Super User/Service Provider/Catalog Manager Only
Image 4 - Survey/Form Builder Screen, Site Admin AND SuperUser/Service Provider/Catalog Manager
Image 5 - Form Builder Association Search
Image 6 - Dashboard View
Image 7 - Proper Step 5 View