JM - (SPARCForms) View Response Likert Bug #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiel86
force-pushed
the
jm-view-response-likert-bug
branch
from
c7bb80e
to
8cad785
Compare
kayla-glick
previously requested changes
May 2, 2018
| @@ -36,7 +36,7 @@ | |||
| .form-group | |||
| %p.question-description | |||
| = raw(question.description) | |||
| .question-options | |||
| .question-options{ id: ['new', 'edit', 'preview'].include?(action_name) ? '' : 'disable-likert' } | |||
There was a problem hiding this comment.
This will give us multiple elements with the same ID which breaks DOM conventions. Is it possible to use a class instead?
There was a problem hiding this comment.
Agreed, this can cause lots of problems, especially in forms.
jleonardw9
dismissed
kayla-glick’s stale review
Id was changed to class, issue is resolved.
jleonardw9
approved these changes
May 8, 2018
Stuart-Johnson
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/156545721
When viewing a user's Survey or Form response with a Likert scale, the user is able to click other Likert options' labels and change the selected radio button. This will not change the data but the radio buttons should not be selectable.