KG - Response Table Header Styling #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiel86
approved these changes
May 29, 2018
royyesud
approved these changes
May 29, 2018
wtholt
approved these changes
May 29, 2018
marklohr
approved these changes
May 29, 2018
Stuart-Johnson
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on https://www.pivotaltracker.com/story/show/156401749
The search in the responses table header was breaking line in Kyle Hutson's browser (see image). I could not replicate this on my machine in Firefox 59.02, Chrome 66.03 or Safari 11.1. This leads me to believe that the issue is due to incompatible styling with older browser versions.
I changed the styles to use Flexbox CSS which is a more reliable solution. Hopefully this will resolve the issue.