Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funding documents table improvement [#157677166] #1336

Merged
merged 6 commits into from Jun 15, 2018
Merged

Funding documents table improvement [#157677166] #1336

merged 6 commits into from Jun 15, 2018

Conversation

ying-pbrc
Copy link
Collaborator

amcates
amcates reviewed Jun 14, 2018
View reviewed changes
Copy link
Collaborator

@amcates amcates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between bootstrap-table-export and tableExport? I only ask because we already include bootstrap-table-export

@ying-pbrc
Copy link
Collaborator Author

bootstrap-table-export is an extension of TableExport jquery plugin. bootstrap-table-export won't work if missing any required dependency.
See https://github.com/wenzhixin/bootstrap-table-examples/blob/master/extensions/export.html#L13

@Stuart-Johnson Stuart-Johnson merged commit b3c5411 into v3.3.0 Jun 15, 2018
@Stuart-Johnson Stuart-Johnson deleted the funding-documents-table-improvement branch June 15, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcates amcates amcates left review comments

@Stuart-Johnson Stuart-Johnson Stuart-Johnson approved these changes

@wtholt wtholt wtholt approved these changes

Assignees
No one assigned
Labels
enhancement LA CaTS version 3.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ying-pbrc @amcates @Stuart-Johnson @wtholt