KG - Settings Updates Part 1 #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayla-glick
force-pushed
the
kg-settings_refactors
branch
from
8076900
to
8f2e54d
Compare
Stuart-Johnson
approved these changes
Aug 2, 2018
marklohr
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal: https://www.pivotaltracker.com/story/show/152826724
While working on the documentation for Settings, I realized that the
epicandldapSetting imports still requireepic.ymlandldap.ymlfiles. I rewrote the settings populator to autoload any json files in theconfig/settingsdirectory and create settings (or update existing ones). This allows us to organize settings into different JSON files based on groups.I also renamed several of the epic settings to label them clearly as epic settings, like how the ldap settings are done.
Part 2 of this story will be to update the documentation.